Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[radiothermostat] Add discovery-methods #16768

Merged
merged 2 commits into from
May 24, 2024

Conversation

mlobstein
Copy link
Contributor

@mlobstein mlobstein commented May 16, 2024

Add discovery-methods for addon suggestion finder

depends on openhab/openhab-core#4232

Signed-off-by: Michael Lobstein <michael.lobstein@gmail.com>
@mlobstein mlobstein added the enhancement An enhancement or new feature for an existing add-on label May 16, 2024
Copy link
Contributor

@jlaur jlaur left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! I have added one small question, otherwise LGTM.

Signed-off-by: Michael Lobstein <michael.lobstein@gmail.com>
@mlobstein mlobstein force-pushed the radiothermostat-suggestion-finder branch from 98dee46 to f56159c Compare May 18, 2024 04:31
@mlobstein mlobstein added awaiting other PR Depends on another PR and removed awaiting other PR Depends on another PR labels May 18, 2024
@mlobstein
Copy link
Contributor Author

The core PR is merged. This can be merged now.

@lsiepel lsiepel merged commit 6e7d64f into openhab:main May 24, 2024
5 checks passed
@lsiepel lsiepel added this to the 4.2 milestone May 24, 2024
@mlobstein mlobstein deleted the radiothermostat-suggestion-finder branch May 25, 2024 00:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement An enhancement or new feature for an existing add-on
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants