[teslapowerwall] Initial contribution #16667

psmedley · 2024-04-20T09:13:45Z

No description provided.

Signed-off-by: Paul Smedley <paul@smedley.id.au>

openhab-bot · 2024-04-25T09:14:15Z

This pull request has been mentioned on openHAB Community. There might be relevant details there:

https://community.openhab.org/t/tesla-powerwall-2-integration/63516/280

Signed-off-by: Paul Smedley <paul@smedley.id.au>

lolodomo · 2024-05-25T12:44:42Z

I added the tag "work in progress" as "WIP" is still in the PR title.
Let us know when this is no more "work in progress".

psmedley · 2024-05-25T20:16:09Z

I think the code is as good as it's going to get, the readme perhaps still needs some work

lolodomo · 2024-05-26T14:28:15Z

If it is ready/finished, please remove "WIP" from PR title.

lsiepel

Thank you for this contribution. I did a full review. There are some things to fix.
Please also fix any remaining SAT errors and compile warnings.

bundles/org.openhab.binding.teslapowerwall/README.md

...werwall/src/main/java/org/openhab/binding/teslapowerwall/internal/TeslaPowerwallHandler.java

Co-authored-by: lsiepel <leosiepel@gmail.com> Signed-off-by: Paul Smedley <paul@smedley.id.au>

…penhab/binding/teslapowerwall/internal/TeslaPowerwallHandler.java Co-authored-by: lsiepel <leosiepel@gmail.com> Signed-off-by: Paul Smedley <paul@smedley.id.au>

Signed-off-by: Paul Smedley <paul@smedley.id.au>

psmedley · 2024-06-03T10:19:31Z

Thank you for this contribution. I did a full review. There are some things to fix. Please also fix any remaining SAT errors and compile warnings.

I fixed most of the warnings - will investigate the "Redundant null check" ones later in the week.

Signed-off-by: Paul Smedley <paul@smedley.id.au>

psmedley · 2024-06-04T02:55:44Z

All warnings resolved, I believe this is ready for re-review now.

lsiepel

Thanks for the quick response. Found some more issues, also some comments from the previous round are not fixed. I guess those are missed becase they are behind the 'show more' button.

bundles/org.openhab.binding.teslapowerwall/README.md

...werwall/src/main/java/org/openhab/binding/teslapowerwall/internal/TeslaPowerwallHandler.java

Co-authored-by: lsiepel <leosiepel@gmail.com> Signed-off-by: Paul Smedley <paul@smedley.id.au>

Signed-off-by: Paul Smedley <paul@smedley.id.au>

…penhab/binding/teslapowerwall/internal/TeslaPowerwallHandler.java Co-authored-by: lsiepel <leosiepel@gmail.com> Signed-off-by: Paul Smedley <paul@smedley.id.au>

…penhab/binding/teslapowerwall/internal/TeslaPowerwallCommunicationException.java Co-authored-by: lsiepel <leosiepel@gmail.com> Signed-off-by: Paul Smedley <paul@smedley.id.au>

jlaur

It seems I have some old pending comment, I'll take the chance and post it to publish my new comment. :)

bundles/org.openhab.binding.teslapowerwall/src/main/resources/OH-INF/update/instructions.xml

...wall/src/main/java/org/openhab/binding/teslapowerwall/internal/TeslaPowerwallWebTargets.java

Signed-off-by: Paul Smedley <paul@smedley.id.au>

Co-authored-by: lsiepel <leosiepel@gmail.com> Signed-off-by: Paul Smedley <paul@smedley.id.au>

Signed-off-by: Paul Smedley <paul@smedley.id.au>

psmedley · 2024-06-06T07:23:34Z

OK - I think I've resolved all concerns.

Signed-off-by: Paul Smedley <paul@smedley.id.au>

lsiepel

I think these are my final comments. Thanks for addressing all issues quick. With this pace we can merge this binding before next stable.

bundles/org.openhab.binding.teslapowerwall/README.md

...rc/main/java/org/openhab/binding/teslapowerwall/internal/TeslaPowerwallBindingConstants.java

...werwall/src/main/java/org/openhab/binding/teslapowerwall/internal/TeslaPowerwallHandler.java

...wall/src/main/java/org/openhab/binding/teslapowerwall/internal/TeslaPowerwallWebTargets.java

bundles/org.openhab.binding.teslapowerwall/src/main/resources/OH-INF/thing/thing-types.xml

…penhab/binding/teslapowerwall/internal/TeslaPowerwallHandler.java Co-authored-by: lsiepel <leosiepel@gmail.com> Signed-off-by: Paul Smedley <paul@smedley.id.au>

Signed-off-by: Paul Smedley <paul@smedley.id.au>

psmedley added 6 commits April 20, 2024 18:23

Make it build

25be11e

Signed-off-by: Paul Smedley <paul@smedley.id.au>

add missing addon.xml

29252cc

Signed-off-by: Paul Smedley <paul@smedley.id.au>

Reinstate binding/binding.xml

2f14abf

Signed-off-by: Paul Smedley <paul@smedley.id.au>

Add support for degradation and battery capacity

5293456

Signed-off-by: Paul Smedley <paul@smedley.id.au>

Update pom.xml for OH 4.2.0

5139f90

Signed-off-by: Paul Smedley <paul@smedley.id.au>

Fix copyright date

62530e6

Signed-off-by: Paul Smedley <paul@smedley.id.au>

psmedley added the new binding If someone has started to work on a binding. For a new binding PR. label Apr 20, 2024

psmedley requested a review from a team as a code owner April 20, 2024 09:13

psmedley added 3 commits April 20, 2024 18:54

update bom/openhab-addons/pom.xml

d371982

Signed-off-by: Paul Smedley <paul@smedley.id.au>

Fix Warnings

960624a

Signed-off-by: Paul Smedley <paul@smedley.id.au>

Fix units for Battery Capacity

c144810

Signed-off-by: Paul Smedley <paul@smedley.id.au>

psmedley added 5 commits April 29, 2024 17:12

Add missing thingTypeVersion

177886f

Signed-off-by: Paul Smedley <paul@smedley.id.au>

Fix display of units for battery and degradation

3d542f9

Signed-off-by: Paul Smedley <paul@smedley.id.au>

Fudge battery reserve and SOE to better match Tesla app

9f20427

Signed-off-by: Paul Smedley <paul@smedley.id.au>

Report degradation as 0 if current capacity is above 13.5kW

8399d1d

Signed-off-by: Paul Smedley <paul@smedley.id.au>

Fix units for battery reserve

fc0bbde

Signed-off-by: Paul Smedley <paul@smedley.id.au>

lolodomo added the work in progress A PR that is not yet ready to be merged label May 25, 2024

lolodomo removed the work in progress A PR that is not yet ready to be merged label May 26, 2024

psmedley changed the title ~~[teslapowerwall] [WIP] Initial Contribution~~ [teslapowerwall] Initial Contribution May 27, 2024

lsiepel changed the title ~~[teslapowerwall] Initial Contribution~~ [teslapowerwall] Initial contribution Jun 2, 2024

lsiepel requested changes Jun 2, 2024

View reviewed changes

psmedley and others added 5 commits June 3, 2024 18:05

Update bundles/org.openhab.binding.teslapowerwall/README.md

7a66211

Co-authored-by: lsiepel <leosiepel@gmail.com> Signed-off-by: Paul Smedley <paul@smedley.id.au>

Update bundles/org.openhab.binding.teslapowerwall/src/main/java/org/o…

7947b1d

…penhab/binding/teslapowerwall/internal/TeslaPowerwallHandler.java Co-authored-by: lsiepel <leosiepel@gmail.com> Signed-off-by: Paul Smedley <paul@smedley.id.au>

Update bundles/org.openhab.binding.teslapowerwall/src/main/java/org/o…

90bad0b

…penhab/binding/teslapowerwall/internal/TeslaPowerwallHandler.java Co-authored-by: lsiepel <leosiepel@gmail.com> Signed-off-by: Paul Smedley <paul@smedley.id.au>

Update bundles/org.openhab.binding.teslapowerwall/src/main/java/org/o…

00b2379

…penhab/binding/teslapowerwall/internal/TeslaPowerwallHandler.java Co-authored-by: lsiepel <leosiepel@gmail.com> Signed-off-by: Paul Smedley <paul@smedley.id.au>

Provide examples for text based thing, item and sitemap

e526696

Signed-off-by: Paul Smedley <paul@smedley.id.au>

psmedley added 3 commits June 3, 2024 18:28

Update 'channel' to 'channel id'

1cd8548

Signed-off-by: Paul Smedley <paul@smedley.id.au>

Merge branch 'openhab:main' into teslapowerwall-main

f1b97ec

Fix initial batch of warnings

3698b80

Signed-off-by: Paul Smedley <paul@smedley.id.au>

Fix remaining warnings

5927a1f

Signed-off-by: Paul Smedley <paul@smedley.id.au>

psmedley requested a review from lsiepel June 4, 2024 02:55

lsiepel requested changes Jun 4, 2024

View reviewed changes

psmedley and others added 7 commits June 5, 2024 18:15

Update bundles/org.openhab.binding.teslapowerwall/README.md

bcd70b0

Co-authored-by: lsiepel <leosiepel@gmail.com> Signed-off-by: Paul Smedley <paul@smedley.id.au>

Update bundles/org.openhab.binding.teslapowerwall/README.md

fce6f72

Co-authored-by: lsiepel <leosiepel@gmail.com> Signed-off-by: Paul Smedley <paul@smedley.id.au>

Update bundles/org.openhab.binding.teslapowerwall/README.md

36475c1

Co-authored-by: lsiepel <leosiepel@gmail.com> Signed-off-by: Paul Smedley <paul@smedley.id.au>

Update bundles/org.openhab.binding.teslapowerwall/README.md

e262428

Co-authored-by: lsiepel <leosiepel@gmail.com> Signed-off-by: Paul Smedley <paul@smedley.id.au>

Adapt channel names

e088d89

Signed-off-by: Paul Smedley <paul@smedley.id.au>

Update bundles/org.openhab.binding.teslapowerwall/src/main/java/org/o…

30127d5

…penhab/binding/teslapowerwall/internal/TeslaPowerwallHandler.java Co-authored-by: lsiepel <leosiepel@gmail.com> Signed-off-by: Paul Smedley <paul@smedley.id.au>

Update bundles/org.openhab.binding.teslapowerwall/src/main/java/org/o…

b85e5f4

…penhab/binding/teslapowerwall/internal/TeslaPowerwallCommunicationException.java Co-authored-by: lsiepel <leosiepel@gmail.com> Signed-off-by: Paul Smedley <paul@smedley.id.au>

jlaur reviewed Jun 5, 2024

View reviewed changes

bundles/org.openhab.binding.teslapowerwall/src/main/resources/OH-INF/update/instructions.xml Outdated Show resolved Hide resolved

...wall/src/main/java/org/openhab/binding/teslapowerwall/internal/TeslaPowerwallWebTargets.java Outdated Show resolved Hide resolved

psmedley and others added 4 commits June 6, 2024 06:36

Get it building again

e1ed433

Signed-off-by: Paul Smedley <paul@smedley.id.au>

Update bundles/org.openhab.binding.teslapowerwall/README.md

88eb528

Co-authored-by: lsiepel <leosiepel@gmail.com> Signed-off-by: Paul Smedley <paul@smedley.id.au>

Fix compilation

18e22e9

Signed-off-by: Paul Smedley <paul@smedley.id.au>

Refactor code

9630558

Signed-off-by: Paul Smedley <paul@smedley.id.au>

psmedley requested a review from lsiepel June 6, 2024 07:23

README.md updates

7c57a47

Signed-off-by: Paul Smedley <paul@smedley.id.au>

psmedley mentioned this pull request Jun 6, 2024

[amberelectric] Initial contribution #16850

Open

lsiepel requested changes Jun 6, 2024

View reviewed changes

psmedley and others added 4 commits June 7, 2024 06:39

Update bundles/org.openhab.binding.teslapowerwall/src/main/java/org/o…

9593d80

…penhab/binding/teslapowerwall/internal/TeslaPowerwallHandler.java Co-authored-by: lsiepel <leosiepel@gmail.com> Signed-off-by: Paul Smedley <paul@smedley.id.au>

Code cleanups

f504dc0

Signed-off-by: Paul Smedley <paul@smedley.id.au>

Code improvements

882999d

Code improvements

4e9057a

Signed-off-by: Paul Smedley <paul@smedley.id.au>

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[teslapowerwall] Initial contribution #16667

[teslapowerwall] Initial contribution #16667

psmedley commented Apr 20, 2024

openhab-bot commented Apr 25, 2024

lolodomo commented May 25, 2024

psmedley commented May 25, 2024

lolodomo commented May 26, 2024

lsiepel left a comment

psmedley commented Jun 3, 2024

psmedley commented Jun 4, 2024

lsiepel left a comment

jlaur left a comment

psmedley commented Jun 6, 2024

lsiepel left a comment

[teslapowerwall] Initial contribution #16667

Are you sure you want to change the base?

[teslapowerwall] Initial contribution #16667

Conversation

psmedley commented Apr 20, 2024

openhab-bot commented Apr 25, 2024

lolodomo commented May 25, 2024

psmedley commented May 25, 2024

lolodomo commented May 26, 2024

lsiepel left a comment

Choose a reason for hiding this comment

psmedley commented Jun 3, 2024

psmedley commented Jun 4, 2024

lsiepel left a comment

Choose a reason for hiding this comment

jlaur left a comment

Choose a reason for hiding this comment

psmedley commented Jun 6, 2024

lsiepel left a comment

Choose a reason for hiding this comment