-
-
Notifications
You must be signed in to change notification settings - Fork 417
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support for openfl.filters.BevelFilter #2665
base: 9.4.0-Dev
Are you sure you want to change the base?
Conversation
…ine style (closes openfl#2659) The null default values from the lineStyle() function signature were propagating and being converted to 0, which changed the caps/joints style when running drawGraphicsData() with the result of readGraphicsData()
Since the measurement cache can be problematic in some use cases, I decided to include the `skip_measurement_cache` flag in the internals. This define is likely to become obsolete and removed in future versions.
Implements openfl.filters.BevelFilter
I switched the base branch to 9.4.0-Dev since the 9.3.0 release is happening soon, and this should have more time for testing once merged. |
Taking care of the extra area caused by applying this filter to a DisplayObject
This works correctly in Chrome and Safari. However, in Firefox, there's an exception thrown. If you can fix it, I'll be happy to merge!
|
@scanline were you able to fix the issue happening on Firefox? |
At the moment the BevelFilter is completely missing - not even a stub. A quick example like this:
which the Flashplayer displays like this:
just throws Type not found : openfl.filters.BevelFilter when targeting e.g. html5.
With this pull request OpenFL now supports the complete features of the BevelFilter and things will look like this:
BitmapFilterType.INNER
withknockout
set to true and false work flawlesslywhile.BitmapFilterType.OUTER
andBitmapFilterType.FULL
suffer from the same fate as any other of OpenFL's OpenGL-based filters (GlowFilter and the like):OpenFL does not allow dynamic resizing of textures to make room for the filter's effect