-
Notifications
You must be signed in to change notification settings - Fork 515
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix gpuCost computation error #2658
base: v1.109
Are you sure you want to change the base?
Conversation
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
@ElieLiabeuf thanks for the contribution. Could you sign your commit and fix the DCO warning? This looks relatively straightforward |
Signed-off-by: Elie Liabeuf <elie.liabeuf@mindee.co>
It's fixed, thanks. |
@AjayTripathy you asked him to contribute this patch in #2657, could you review? |
@ElieLiabeuf this generally LGTM but I'm struggling to test this on my end without shared GPUs. Could you share how you tested and verified this fix? In particular, could you share the results of /costDataModel after the fix along with node labels? I think that should be sufficient to get this merged. |
What does this PR change?
Solve gpuCost computation error
Does this PR address any GitHub or Zendesk issues?
Closes #2657
Does this PR require changes to documentation?
No