Make CorrectForPH respect perceived chains. #2678
Open
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes #2677
CorrectForPH currently clears all perceived attributes through mol.EndModify(). In my change, I check if chains are perceived before hand and in that case sets them as perceived also after since normally the residues and chains shouldn't change through pH-correction.
However, this is a breaking change if someone previously relied on the old behavior. In that case they need to manually reperceive the chains after the call to CorrectForPH (or reset the flag before...).