Wiswesser #2591
Open
Wiswesser #2591
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 18 commits
May 7, 2023 19:04
…tricter on branches implied by smiles
![sonatype-lift[bot]](https://avatars.githubusercontent.com/in/9843?s=60&v=4){kind=small}
| WLNSymbol *prev = head; | ||
| for(unsigned int i=0;i<size-1;i++){ | ||
| WLNSymbol* carbon = AllocateWLNSymbol('1',graph); | ||
| carbon->set_edge_and_type(4); // allows hydrogen resolve |
There was a problem hiding this comment.
NULL_DEREFERENCE: pointer carbon last assigned on line 1293 could be null and is dereferenced at line 1294, column 5.
❗❗ 7 similar findings have been found in this PR
🔎 Expand here to view all instances of this finding
ℹ️ Expand to see all @sonatype-lift commands
You can reply with the following commands. For example, reply with @sonatype-lift ignoreall to leave out all findings.
| Command | Usage |
|---|---|
@sonatype-lift ignore |
Leave out the above finding from this PR |
@sonatype-lift ignoreall |
Leave out all the existing findings from this PR |
@sonatype-lift exclude <file|issue|path|tool> |
Exclude specified file|issue|path|tool from Lift findings by updating your config.toml file |
Note: When talking to LiftBot, you need to refresh the page to see its response.
Click here to add LiftBot to another repo.
added 2 commits
May 10, 2023 14:45
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Apologies! learning how SWIG works so i've refactored this commit, i've also updated the test to be stricter on the SMILES
ordering.
valgrind test - no leaks
Wiswesser Reader Release Notes
The following are sections from Elbert G. Smiths rule book that were used to create
the wln reader. Note that not all chapters are listed here, only the ones where compound
types were introduced
Rules fully supported
Rules unsupported