Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

use simple cube format for molecules with single grid #2580

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

correaa
Copy link

@correaa correaa commented Mar 29, 2023

No description provided.

@correaa correaa marked this pull request as draft March 29, 2023 05:27
@correaa correaa changed the title use simple cube format for molecules with simple grid use simple cube format for molecules with single grid Mar 29, 2023
@correaa
Copy link
Author

correaa commented Mar 29, 2023

I tested the changes on the resulting files read from VESTA and VisIt.
Any feedback is welcome.

@correaa correaa marked this pull request as ready for review April 6, 2023 04:20
@correaa
Copy link
Author

correaa commented Apr 6, 2023

I propose to default to the (simpler) format (a) in the case that there is only one grid associated with the molecule.
Having one grid is very common and it is also common that other programs only format (a) anyway.

Please let me know if for some reason this is not acceptable and what I can do to fix it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants