Allow GUI to compile with wxWidgets built with STL #2527
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wxMenuItemList - a wxList of wxMenuItems - should be iterated using the wxMenuItemList::compatibility_iterator so that it can be compiled with wxWidgets built with STL. This commit does not make GUI require wxWidgets > 2.8 nor wxWidgets compiled with STL but makes the code compatible with more recent versions of wxWidgets compiled with STL. See also: https://wiki.wxwidgets.org/Updating_to_the_Latest_Version_of_wxWidgets#wxUSE_STL.
|
Thanks for opening this pull request! Please check out our contributing guidelines and please examine any build issues. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
wxMenuItemList- awxListofwxMenuItems - should be iterated using thewxMenuItemList::compatibility_iteratorso that it can be compiled with wxWidgets built with STL.This commit does not make GUI require wxWidgets > 2.8 nor wxWidgets compiled with STL but makes the code compatible with more recent versions of wxWidgets compiled with STL.
See also the wxWidgets wiki about this topic.