Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Reimplement OpenBabel::OBRandom as a wrapper of std::mt19937_64 #2241

Open
wants to merge 9 commits into
base: master
Choose a base branch
from
Open

Reimplement OpenBabel::OBRandom as a wrapper of std::mt19937_64 #2241

wants to merge 9 commits into from

Commits on Oct 24, 2023

  1. chore: remove unnecessary forward declaration

    @e-kwsm
    e-kwsm committed Oct 24, 2023
    Configuration menu
    Copy the full SHA
    cb828aa View commit details
    Browse the repository at this point in the history

  2. chore: do not use pointer unnecessarily

    @e-kwsm
    e-kwsm committed Oct 24, 2023
    Configuration menu
    Copy the full SHA
    a32f335 View commit details
    Browse the repository at this point in the history

  3. refactor: use std::unique_ptr for OpenBabel::OBConformerSearch::d

    @e-kwsm
    e-kwsm committed Oct 24, 2023
    Configuration menu
    Copy the full SHA
    a090b6b View commit details
    Browse the repository at this point in the history

  4. feat: add PRNG-related methods to OpenBabel::OBRandom 

    - UniformInt
- UniformReal
- Normal
- Bernoulli
    @e-kwsm
    e-kwsm committed Oct 24, 2023
    Configuration menu
    Copy the full SHA
    64aadfa View commit details
    Browse the repository at this point in the history

  5. refactor: use newly-added OpenBabel::OBRandom methods

    @e-kwsm
    e-kwsm committed Oct 24, 2023
    Configuration menu
    Copy the full SHA
    2657cdb View commit details
    Browse the repository at this point in the history

  6. feat: implement OpenBabel::OBRandomMT as a wrapper of std::mt19937_64 

    deprecates OpenBabel::OBRandom
    @e-kwsm
    e-kwsm committed Oct 24, 2023
    Configuration menu
    Copy the full SHA
    e87b4e2 View commit details
    Browse the repository at this point in the history

  7. refactor: improve method to generate 3-D random unit vector 

    this is enabled if OB_USE_IMPROVED_RANDOM_UNIT_VECTOR, which defaults to
whether OpenBabel 4 is released or not, is defined as truthy
    @e-kwsm
    e-kwsm committed Oct 24, 2023
    Configuration menu
    Copy the full SHA
    1960c62 View commit details
    Browse the repository at this point in the history

  8. refactor: switch to OBRandomMT if OB_USE_OBRANDOMMT is defined as truthy 

    the macro defaults to whether OpenBabel 4 is released or not
    @e-kwsm
    e-kwsm committed Oct 24, 2023
    Configuration menu
    Copy the full SHA
    62a80cb View commit details
    Browse the repository at this point in the history

  9. docs: add explanations of OB_RANDOM_SEED environment variable

    @e-kwsm
    e-kwsm committed Oct 24, 2023
    Configuration menu
    Copy the full SHA
    4527e2c View commit details
    Browse the repository at this point in the history