New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Tidy up #2091
base: master
Are you sure you want to change the base?
Tidy up #2091
Conversation
Why? For many reasons, we removed the math checks because they're very slow. |
|
I've had this debate before - if there's a crash, the problem is in the calling code (e.g., GetNewBondVector in your linked example). This code is called a lot in tight loops. Many builds are RelWithDebInfo which would still enable your checks. |
Change about |
return _vz; | ||
default: | ||
cerr << "ERROR in OpenBabel::vector3::operator[]\n" | ||
<< "The method has been called with an illegal index i=" << i << ".\n" | ||
<< "Please contact the author of the offending program immediately." << endl; |
This comment was marked as resolved.
This comment was marked as resolved.
Sorry, something went wrong.
#2088