Display signatures on Public Keys when present #419
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ed keyring There may be a better way to display this information. This is only a first cut. Most signatures are likely to be unknown. Label these as simply "Signature". In the case that a signature is already in the trusted keyring, label it "Trusted signature".
There are at least two pieces of information that we need to display for each signature: the "familiarity" of the signature (unknown, known, or trusted) and the key ID of the signature. This data might be easier to display to the user in a tabular format, as in this commit.
dwymark
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Display information about signatures on public keys which is collected by libzypp via libzypp PR 354. Display this information in a manner which is informative while not being confusing.
This work is being done with zypper issue 348 in mind.