osc:build: Avoid piping "yes" when build root is broken #40
Conversation
|
If you wonder about the other |
| command << " --root=/var/tmp/build-root-#{build_dist}" | ||
| command << " --root=#{broot}" | ||
| # avoid an interactive question, bsc#1053839 | ||
| if File.exist?("#{broot}/not-ready") |
There was a problem hiding this comment.
ugh, what? who create file? where it is documented? any documentation for that not-ready file would be good. Do not forget that this packaging rake tasks is used for multiple projects, not only libstorage or yast.
There was a problem hiding this comment.
I think I see your point.
This PR replaces a yes | workaround by something which is still a workaround. not-ready is an implementation detail of init_buildsystem, which is part of build.rpm, on which osc depends.
I considered init_buildsystem a more stable thing than osc. Do you think we should press to have https://bugzilla.suse.com/show_bug.cgi?id=1053839 fixed instead?
There was a problem hiding this comment.
upstream fixes is always nice to have :), but if you document this, I am, also fine with this File exists stuff
| @@ -159,12 +159,17 @@ namespace :osc do | |||
| Dir.chdir osc_checkout_dir do | |||
| puts "building package..." if verbose | |||
|
|
|||
| # pipe yes to osc build to automatic rebuild broken build root if it happen | |||
| command = "yes | osc -A '#{obs_api}' build" | |||
| # have separated roots per target system, so sharing is more efficient | |||
There was a problem hiding this comment.
I see twice identical comment, see line 167
bsc#1053839