disable kernel multiversion setting (boo#1172229) #234
Conversation
|
|
||
| MIL << "Parsing keep spec: " << _keepSpec << std::endl; | ||
|
|
||
| std::vector<std::string> words; | ||
| str::split( _keepSpec, std::back_inserter(words), ",", str::TRIM ); | ||
| if ( words.empty() ) { | ||
| WAR << "Invalid keep spec: " << _keepSpec << " using default latest,running." << std::endl; | ||
| return; | ||
| WAR << "Invalid keep spec: " << _keepSpec << " using default latest,latest-1,running." << std::endl; |
There was a problem hiding this comment.
Should we really just fall back to the default keep spec if the admin speficied a incorrect one? That might result in purging kernels and packages that should not be purged. IMO its better to error out in that case.
There was a problem hiding this comment.
maybe but that would be separate change. The previous code just skipped the parsing in error case so used the global defaults of those variables. Ie equivalent to "latest,running". That's even less than the config file default of "latest,latest-1,running". So this change is for consistency.
|
@lnussel boo#1172229 is about transactional systems. Your patch here would change everything down to SLE/LEAP 15.0. I don't think we want this. I'll try provide a way to ship an empty zypp.conf in the future, keeping our current defaults, unless all TW and SLE15 stakeholders conclude that no-multiversion kernel shall be the new default for all those distros from now on. |
Eh, don't you have branches? :)
Yes, that's the idea. So far I was thinking of moving the config to the purge-kernel-service but the maintainer had concerns that the setting and the service might not necessarily related. So instead we could create a subpackge of libzypp or zypper for that. |
|
We do have branches and master (libzypp-17.x) e.g. feeds TW and the SLE15 family. |
Will be set by the purge-kernels-service package instead.
This avoids an explicit setting in the config
This reflects openSUSE defaults and avoids to ship an explicit setting override via config.
|
This change should be done at image composition time, no? And for transactional-server role in YaST, can't we include an action there to set this properly? |
No description provided.