Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

minor: add isApplicationLoading state in ApplicationStore #16242

Merged
merged 14 commits into from May 15, 2024

Conversation

Sachin-chaurasiya
Copy link
Member

@Sachin-chaurasiya Sachin-chaurasiya commented May 13, 2024

Describe your changes:

I worked on adding isApplicationLoading in isApplicationLoading to show the loader at the application level when the application is in a loading state which could be fetching config or fetching logged-in user details.

Tested Provider

  • Google (confidential and public both)
  • Okta
  • Auth0
  • Basic
  • LDAP
  • Saml
  • Azure
  • Saml

Type of change:

  • Improvement

Checklist:

  • I have read the CONTRIBUTING document.
  • My PR title is Fixes <issue-number>: <short explanation>
  • I have commented on my code, particularly in hard-to-understand areas.
  • For JSON Schema changes: I updated the migration scripts or explained why it is not needed.

@Sachin-chaurasiya Sachin-chaurasiya self-assigned this May 13, 2024
@github-actions github-actions bot added UI UI specific issues safe to test Add this label to run secure Github workflows on PRs labels May 13, 2024
Copy link

github-actions bot commented May 13, 2024

Jest test Coverage

UI tests summary

Lines Statements Branches Functions
Coverage: 64%
64.77% (34748/53645) 41.6% (13697/32924) 43.56% (4262/9785)

@Sachin-chaurasiya Sachin-chaurasiya changed the title minor: add isApplicationLoading state and ApplicationStore minor: add isApplicationLoading state in ApplicationStore May 13, 2024
@Sachin-chaurasiya Sachin-chaurasiya marked this pull request as ready for review May 13, 2024 17:17
Copy link

sonarcloud bot commented May 15, 2024

@chirag-madlani chirag-madlani merged commit 80ccb4e into main May 15, 2024
15 of 17 checks passed
@chirag-madlani chirag-madlani deleted the application-loader branch May 15, 2024 10:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
safe to test Add this label to run secure Github workflows on PRs UI UI specific issues
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants