New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
minor: add isApplicationLoading state in ApplicationStore #16242
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
UI
UI specific issues
safe to test
Add this label to run secure Github workflows on PRs
labels
May 13, 2024
Sachin-chaurasiya
changed the title
minor: add isApplicationLoading state and ApplicationStore
minor: add isApplicationLoading state in ApplicationStore
May 13, 2024
Sachin-chaurasiya
requested review from
harshach,
karanh37 and
chirag-madlani
as code owners
May 13, 2024 17:17
… Callback onSuccess
Quality Gate passed for 'open-metadata-ui'Issues Measures |
chirag-madlani
approved these changes
May 15, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Describe your changes:
I worked on adding isApplicationLoading in isApplicationLoading to show the loader at the application level when the application is in a loading state which could be fetching config or fetching logged-in user details.
Tested Provider
Type of change:
Checklist:
Fixes <issue-number>: <short explanation>