New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fixes: 15835 : Sign-in issues for users imported via CSV. #16227
Fixes: 15835 : Sign-in issues for users imported via CSV. #16227
Conversation
…rough CSV to prevent any mismatch between name and email. Removed preferred_username and sub from JWT principal claims.
Hi there 👋 Thanks for your contribution! The OpenMetadata team will review the PR shortly! Once it has been labeled as Let us know if you need any help! |
The Java checkstyle failed. Please run You can install the pre-commit hooks with |
conf/openmetadata.yaml
Outdated
@@ -174,7 +174,7 @@ authenticationConfiguration: | |||
authority: ${AUTHENTICATION_AUTHORITY:-https://accounts.google.com} | |||
clientId: ${AUTHENTICATION_CLIENT_ID:-""} | |||
callbackUrl: ${AUTHENTICATION_CALLBACK_URL:-""} | |||
jwtPrincipalClaims: ${AUTHENTICATION_JWT_PRINCIPAL_CLAIMS:-[email,preferred_username,sub]} | |||
jwtPrincipalClaims: ${AUTHENTICATION_JWT_PRINCIPAL_CLAIMS:-[email]} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
why are we changing this?
@mohityadav766 @Siddhanttimeline the goal here is to make sure that preferred_username matches the user's email. |
Quality Gate passed for 'open-metadata-ingestion'Issues Measures |
Describe your changes:
Fixes : 15835
I worked on ... because ...
The users imported via CSV were unable to sign in, instead, they were redirected to the sign-up page. This occurred because the users imported via CSV lacked validation for their names and emails, leading to a mismatch between the name and email. This discrepancy is affecting user sign-in.
To resolve this :
Type of change:
Checklist:
Fixes <issue-number>: <short explanation>