Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MINOR: add debug tool in ingestion Dockerfile #16226

Closed
wants to merge 1 commit into from

Conversation

HuanjieGuo
Copy link
Contributor

Describe your changes:

add vim, PS, telnet in ingestion image.

  • vim: change the source code or json file sometimes.
  • procps: use it to check the workflow process.
  • telnet: check the network.

I worked on enhance the ingestion Dockerfile because I deployed it in my env and found that it lacks a lot of necessary commands.

Type of change:

  • Improvement

Checklist:

  • I have read the CONTRIBUTING document.
  • My PR title is Fixes <issue-number>: <short explanation>
  • I have commented on my code, particularly in hard-to-understand areas.
  • For JSON Schema changes: I updated the migration scripts or explained why it is not needed.

@HuanjieGuo HuanjieGuo requested a review from a team as a code owner May 10, 2024 15:20
Copy link

Hi there 👋 Thanks for your contribution!

The OpenMetadata team will review the PR shortly! Once it has been labeled as safe to test, the CI workflows
will start executing and we'll be able to make sure everything is working as expected.

Let us know if you need any help!

Copy link
Contributor

@TeddyCr TeddyCr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @HuanjieGuo for the PR. The best approach here would be for you to extend the Docker image for your use case. We will not be adding additional dependencies that are not required to run the ingestion.

cc @pmbrull for second opinion.

@pmbrull
Copy link
Collaborator

pmbrull commented May 17, 2024

Thanks @HuanjieGuo for the PR. The best approach here would be for you to extend the Docker image for your use case. We will not be adding additional dependencies that are not required to run the ingestion.

cc @pmbrull for second opinion.

Hi, agree with @TeddyCr. We need to keep the final image as slim as possible.

If you need debugging capabilities for development, we can discuss to have them added to the Dockerfile.ci one.

Appreciate you openning the PR, but I am afraid it's not something we can't merge.

Thanks

@pmbrull pmbrull closed this May 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants