Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(ui): what's new details update for 1.4.0 #16146

Merged
merged 13 commits into from May 16, 2024
Merged

Conversation

Ashish8689
Copy link
Contributor

@Ashish8689 Ashish8689 commented May 7, 2024

Describe your changes:

Fixes

Fixes: Update what's new content for 1.4.0

image image image image image image image
Screen.Recording.2024-05-16.at.3.34.35.PM.mov

Type of change:

  • Bug fix
  • Improvement
  • New feature
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation

Checklist:

  • I have read the CONTRIBUTING document.
  • My PR title is Fixes <issue-number>: <short explanation>
  • I have commented on my code, particularly in hard-to-understand areas.
  • For JSON Schema changes: I updated the migration scripts or explained why it is not needed.

@Ashish8689 Ashish8689 added the UI UI specific issues label May 7, 2024
@Ashish8689 Ashish8689 self-assigned this May 7, 2024
@github-actions github-actions bot added the safe to test Add this label to run secure Github workflows on PRs label May 7, 2024
Copy link

github-actions bot commented May 10, 2024

Jest test Coverage

UI tests summary

Lines Statements Branches Functions
Coverage: 64%
64.76% (34778/53699) 41.57% (13704/32963) 43.57% (4265/9788)

@Ashish8689 Ashish8689 marked this pull request as draft May 16, 2024 05:51
karanh37
karanh37 previously approved these changes May 16, 2024
- bootstrap/bootstrap_storage.sh has been deprecated in favor of bootstrap/openmetadata-ops.sh

UI:

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No need for extra space after sub-header for UI and API sections


- Activity has been improved. New update specific cards display critical information such as data quality test case updates, description, tag update or removal.
- For Lineage, the Expand All button has been removed. A new Layers button is introduced at the bottom left corner. With the Layers button, you can add Column Level Lineage or Data Observability details to your Lineage view.
- View Definition is now renamed to Schema Definition.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

renamed "as"

pmbrull
pmbrull previously approved these changes May 16, 2024
- For Lineage, the Expand All button has been removed. A new Layers button is introduced at the bottom left corner. With the Layers button, you can add Column Level Lineage or Data Observability details to your Lineage view.
- View Definition is now renamed to Schema Definition.
- Adding Glossary Term view is improved. Now we show glossary terms hierarchically enabling a better understanding of how the terms are setup while adding it to a table or dashboard.
- For Classification, users can set classification to be mutually exclusive only at the creation time. Once created, you cannot change it back to mutually non-exclusive or vice-versa. This is to prevent conflicts of adding multiple tags that belong to same classification and later turning the mutually exclusive flag back to true.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

For Classification, users can set classification to be mutually exclusive only **at the time of creation**. Once created, you cannot change it back to mutually non-exclusive or vice-versa. This is to prevent conflicts of adding multiple tags that belong to same classification and later turning the mutually exclusive flag back to true.

ShilpaVernekar
ShilpaVernekar previously approved these changes May 16, 2024
Copy link
Contributor

@ShilpaVernekar ShilpaVernekar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just some minor changes needed

@chirag-madlani chirag-madlani merged commit 82143e2 into main May 16, 2024
10 of 12 checks passed
@chirag-madlani chirag-madlani deleted the whats-new-1.4.0 branch May 16, 2024 11:22
Copy link

sonarcloud bot commented May 16, 2024

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
e2e:Observability safe to test Add this label to run secure Github workflows on PRs UI UI specific issues
Projects
Status: No status
Development

Successfully merging this pull request may close these issues.

None yet

7 participants