Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FIX #16005 - database & databaseSchema should not be stored in table_entity json (#16005) #16006

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

zjffdu
Copy link

@zjffdu zjffdu commented Apr 24, 2024

Describe your changes:

Fixes 16005, make the following changes

  1. Update TableRepository to unset databaseSchema & database before storing.
  2. Update DatabaseSchemaRepository to unset database before storing.

The reason is that those relationship should be stored in entity_relationship.

Type of change:

  • Bug fix
  • Improvement
  • New feature
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation

Checklist:

  • I have read the CONTRIBUTING document.
  • My PR title is Fixes <issue-number>: <short explanation>
  • I have commented on my code, particularly in hard-to-understand areas.

@zjffdu zjffdu requested a review from a team as a code owner April 24, 2024 04:06
Copy link

Hi there 👋 Thanks for your contribution!

The OpenMetadata team will review the PR shortly! Once it has been labeled as safe to test, the CI workflows
will start executing and we'll be able to make sure everything is working as expected.

Let us know if you need any help!

@harshach harshach added the safe to test Add this label to run secure Github workflows on PRs label Apr 24, 2024
harshach
harshach previously approved these changes Apr 24, 2024
@harshach
Copy link
Collaborator

Thanks for the quick fix @zjffdu

Copy link

The Java checkstyle failed.

Please run mvn spotless:apply in the root of your repository and commit the changes to this PR.
You can also use pre-commit to automate the Java code formatting.

You can install the pre-commit hooks with make install_test precommit_install.

@zjffdu zjffdu changed the title FIX #16005 - Database & databaseSchema should not be stored in table_entity json (#16005) FIX #16005 - database & databaseSchema should not be stored in table_entity json (#16005) Apr 24, 2024
@zjffdu zjffdu force-pushed the 16005 branch 2 times, most recently from a906dfd to 7e3710c Compare April 27, 2024 14:41
Copy link

sonarcloud bot commented May 8, 2024

Quality Gate Passed Quality Gate passed for 'open-metadata-ingestion'

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
No data about Duplication

See analysis details on SonarCloud

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backend safe to test Add this label to run secure Github workflows on PRs
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants