Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jenkins CI support: build step script #1720

Open
wants to merge 2 commits into
base: staging
Choose a base branch
from
Open

Conversation

jelmd
Copy link

@jelmd jelmd commented Jun 24, 2016

This makes it easier to configure Jenkins (what to do when a PR webhook is received): Instead of copying the content of the whole script into the build step 'execute shell', just paste 'ksh93 script/jenkins-pr-job.sh' into it.

@tillmo
Copy link
Member

tillmo commented Jun 28, 2016

@eugenk, please review once you have more time

print -n 'create user ontohub;
create database ontohub OWNER=ontohub;
create database ontohub_test OWNER=ontohub;
create database ontohub_development OWNER=ontohub;
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We only need the database ontohub_test on the CI system because we only run the test environment.

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

So it hurts/causes the tests to not work?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It does not cause the tests not to work. It's just not needed.

@eugenk
Copy link
Member

eugenk commented Jul 26, 2016

Otherwise, it looks okay to me. 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants