1612 handle concurrency of rugged and cli git #1677
Conversation
| end | ||
|
|
||
| # change a single file and commit the change | ||
| def commit_file_without_lock(userinfo, file_contents, target_path, message, &block) |
There was a problem hiding this comment.
Line is too long. [85/80]
Method has too many lines. [22/10]
|
I'll ignore the |
| end | ||
|
|
||
| # change a single file and commit the change | ||
| def commit_file_without_lock(userinfo, |
| @@ -26,6 +26,12 @@ def initialize(repo_path, key_id, refs) | |||
| end | |||
|
|
|||
| def exec | |||
| Semaphore.exclusively("action:#{@repo_name}") do | |||
There was a problem hiding this comment.
Please find a way to only write "action:" once. Maybe put it into a constant or a class method of GitRepository.
And please use git instead of action (we will have many locks with different types and all of them are some kind of action)
phyrog
force-pushed
the
1612-handle_concurrency_of_rugged_and_cli_git
branch
from
55e3375
to
b33e751
Compare
|
I think you could incorporate it as well in lib/git_repository/cloning.rb:98 ( A mirror repository should not be synchronised while another operation is executed on the repository, but a lock shouldn't hurt in this case. |
|
See spec/lib/semaphore_spec.rb for a test that uses fork_break |
phyrog
force-pushed
the
1612-handle_concurrency_of_rugged_and_cli_git
branch
from
b33e751
to
2e4d514
Compare
| end | ||
|
|
||
| # change a single file and commit the change | ||
| def commit_file_without_lock(userinfo, |
There was a problem hiding this comment.
This is not related to the PR, so don't mind.
phyrog
force-pushed
the
1612-handle_concurrency_of_rugged_and_cli_git
branch
from
2e4d514
to
bda5480
Compare
|
Well, except for the yet to be written tests: 👍 |
This should fix #1612