Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use PyQt instead of PySide6 #1887

Open
wants to merge 3 commits into
base: main
Choose a base branch
from
Open

Use PyQt instead of PySide6 #1887

wants to merge 3 commits into from

Conversation

hefee
Copy link

@hefee hefee commented Mar 6, 2024

As described in #1871 the hard Qt6 dependency makes it very hard to backport the newer version for Debian. The PyQt abstraction layer makes Debian free to switch Qt6 if everything is packaged correctly.

Currently marked as Draft, as I only made sure that the test suite passes locally.
Closes: #1871

@hefee hefee requested a review from micahflee as a code owner March 6, 2024 21:59
@hefee hefee changed the title Draft: Use PyQt instead of PySide6 Use PyQt instead of PySide6 Apr 16, 2024
@hefee
Copy link
Author

hefee commented Apr 16, 2024

I have tested it to build an run on Debian successfully. So I think it is ready to merge.

@micahflee
Copy link
Collaborator

Sorry about taking so long to respond. I'd love to get OnionShare packaged in Debian, but I think we should do two things first:

  1. Decide if we want to switch from PySide6 and what the pros (besides Debian support) and cons are, and

  2. Much bigger: make sure this works and is packaged properly in Flatpak and Snapcraft in Linux, as well as Windows and macOS. Unfortunately swapping out a dependency like this could take a considerable amount of work for all the platforms we support.

@hefee
Copy link
Author

hefee commented Apr 17, 2024 via email

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Qt6 depdenency & backport to Debian stable / Tails
2 participants