rfc: proposal to support deterministic primitive execution #1772
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mgouicem
force-pushed
the
mgouicem/determinism
branch
from
a384bfe
to
94341a5
Compare
dzarukin
reviewed
Dec 14, 2023
| We are not proposing a global settting for deterministic behavior as | ||
| those can typically cause unwanted global synchronizations, and do not | ||
| seem to be needed. This can be revised if there is a usage scenario | ||
| for global setting. |
There was a problem hiding this comment.
Are you saying that there's no sense in same calls as we have for fpmath: get_default_fpmath_mode() and set_default_fpmath_mode?
There was a problem hiding this comment.
Yes. For fpmath, we have a global state (default_fpmath_mode) because of the environment variable controls.
For this feature though, there is no request to enable it though an environment variable, so we get to enable it without introducing a global state to the library. I checked with FWK contacts and it seems that passing an attribute is aligned with current FWK implementation (+ @jgong5)
igorsafo
approved these changes
Dec 18, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Link to rendered document