Update node and run-script #3112
Conversation
- Bump node docker image: 14.18 -> 18.16.1 - Bump run-script as workaround for `node-gyp` upstream deprecation (`ValueError: invalid mode: 'rU' while trying to load binding.gyp`) (cf. omnivore-app#2640)
pythoninthegrass
requested review from
satindar,
sywhb and
jacksonh
as code owners
|
@pythoninthegrass is attempting to deploy a commit to the omnivore Team on Vercel. A member of the Team first needs to authorize it. |
|
|
Missed omnivore-app@f581a53#diff-299521ac88d989dd3dd880ad92778c8ba3355ecca81d91da0838eced3e6968ebR14. Added @Samuel-Martineau's relative path to skip copying `selfhost.sh` to top-level directory; still fails without omnivore-app#2640 being resolved.
|
Hey it looks like this one needs to be rebased. Let me know if you don't have time and I'll pull in the other parts. |
pythoninthegrass
force-pushed
the
fix/self-hosting-dockerfile
branch
from
f1298a6
to
93c5073
Compare
…oninthegrass/omnivore into fix/self-hosting-dockerfile
|
Hi @jacksonh, Sorry about that! Looks like in the process of rebasing, I accidentally closed the PR. Believe it's fixed now, but please let me know if that's not the case or you need anything else. |
| @@ -1,4 +1,4 @@ | |||
| FROM node:18.16-alpine as builder | |||
| FROM node:18.16.1-alpine as builder | |||
There was a problem hiding this comment.
Do you know if we need this?
There was a problem hiding this comment.
It's best practice if you want images to work on machines other than yours. By pinning the minor version of the node image, it can still get security updates (vs. pinning manifest), but is guaranteed to work with the version of node Omnivore was tested with.
So for example, I can be fairly confident that we'll always get this
/app # node --version
v18.16.1whereas if you only use the node:18.16-alpine tag, you can end up with v18.6.2 or later (although it appears to get updated every 5-6 months.)
It's your show, so understand if only specifying major/minor version is preferred.
node-gypupstream deprecation (ValueError: invalid mode: 'rU' while trying to load binding.gyp) (cf. Bump node-gyp for local development #2640)