Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Separate record and text in full text search #2152

Open
wants to merge 4 commits into
base: develop
Choose a base branch
from

Conversation

Daniel-KM
Copy link
Contributor

The first commit add an index on is_public, that it was missing in last pr. This is important, because all queries use it, so it speed end users queries a lot.

The second commit separate the fulltext field in a field "record" (for the record) and a field "text" (for the text: transcription, ocr, content, etc.). Many librarians make a distinction between to search the record and to search the content and this hard to manage without recreate another search table. This second commit is complete, but requires some more work, in particular a setting to determine what is full text (bibo:content or extracttext:extracted_text and some other) and another optional setting to let user select full text or not, by default or not. To use the event is possible, but complex.

So you can cherry-pick the first and say me what you think about the second.

@zerocrates
Copy link
Member

Are you seeing big improvements from the is_public index?

My understanding has been that there's really no support for combining the usage of a regular index with a fulltext one, so I'm somewhat surprised there'd be a large improvement there. I'd assume the fulltext would usually be the more specific index and get used.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants