Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Passed resource and value annotation to template for displayValues(). #1999

Open
wants to merge 1 commit into
base: develop
Choose a base branch
from

Conversation

Daniel-KM
Copy link
Contributor

The resource value annotations use the same template than resource values, so it should pass the resource too.

By the way, there is an important missing feature about value annotation : there is no template, so the user should select the properties and the datatype one by one. Most of the time, it's only one or two properties, but it should be listed somewhere, so it can be filled in one click.

So is it better I improve the module Advanced Resource Template for that or to push request here to avoid a future re-implementation, because it is probably something people will want later.

As for many other things, is there a way to know what will be inside the core and what will remain in the modules to avoid to develop the same thing multiple times with subtle variants?

@zerocrates
Copy link
Member

Probably the question about templates applying to the annotations should be an issue of its own, it'll get lost here, even moreso than other things.

On the question of what's in the core and what's in modules, that's probably also a separate issue and if we want to discuss it at any length we should make one for that as well. My short answer is that we of course don't want unnecessary duplication of effort between the core and modules, not only is this unfortunate on its own terms for the developers of both, it's confusing for users.

Some duplication does end up making sense though: modules can demonstrate user interest and needs, and the feature can ultimately make sense being there by default, or it can be easier if it's there for other modules to rely on, or various other reasons. AltText is an example of something I myself did as a module before adding a very similar feature to the core later, similarly we've long had an unreleased module for manually setting the server base URL that I have an eye toward (eventually) moving to the core.

In terms of planning: there's a recently added, very high-level, list of "priorities" in the S dev docs. Of course, our own issues and branches for actual in progress work are openly available here on Github. And coming from the reverse direction, we're happy to get issues and questions coming in about the interest or likelihood of us supporting particular features. In particular, features and setups that allow modules to more easily and reliably accomplish what they need to are something I'm interested in even if we don't want the module itself in the core.

Some of this kind of dialogue we've had in the past and it hasn't always been effective for one reason or another. We pretty recently did a fairly thorough clean-out of the old issues on the tracker with an eye to making sure we wouldn't lose track of things, so please feel free to re-raise an issue if it had gotten lost before.

@Daniel-KM
Copy link
Contributor Author

Ok, I implemented the feature "template for value annotation" in module Advanced Resource Template v3.4.22.
For the current pr, it's still useful.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants