update push to use model.Name #4291
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
reordered this series of prs so push is updated before pull |
BruceMacD
reviewed
Jun 4, 2024
There was a problem hiding this comment.
I think it would be worth adding some better feedback as to why a model name is invalid before merging this:
❯ ./ollama create localhost:6000/nous-hermes-2-mistral -f /Users/bruce/models/nous-hermes-2-mistral/Modelfile
transferring model data
Error: invalid model name
This is a prime candidate for many people ending up in an issue that isn't related to their specific problem, due to the generic error message.
| } | ||
|
|
||
| manifest, _, err := GetManifest(mp) | ||
| scheme := "https" |
There was a problem hiding this comment.
cc: @bmizerany
I know you were making changes in this area recently, so just a heads up of the scheme changes here.
There was a problem hiding this comment.
All good. I had a little bridge patch. Landing the fix I had is still fair game, and it looks like this is a winner.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
follow up to #4290