ofi_list: Add dlist_size and slist_size #9360
Conversation
sunkuamzn
force-pushed
the
dlist-size
branch
2 times, most recently
from
75e6580
to
ef073ff
Compare
|
AWS CI failures are static assert failures. I will fix them. |
include/ofi_list.h
Outdated
| @@ -388,11 +388,13 @@ struct slist_entry { | |||
| struct slist { | |||
| struct slist_entry *head; | |||
| struct slist_entry *tail; | |||
| OFI_DBG_VAR(size_t, size); | |||
There was a problem hiding this comment.
Because of how this macro works, we can't add the ';' at the end of the line. Some compilers don't like that.
| static inline size_t slist_size(struct slist *list) | ||
| { | ||
| return list->size; | ||
| } |
There was a problem hiding this comment.
Please add a non-debug version of this function that returns 0, so apps can just use it (e.g. in a log message) without guarding the code with debug checks.
We could consider changing the return type to ssize_t and return -1 in the free build as well, to better indicate that the value isn't known.
include/ofi_list.h
Outdated
| @@ -57,15 +57,23 @@ enum ofi_list_end { | |||
| struct dlist_entry { | |||
| struct dlist_entry *next; | |||
| struct dlist_entry *prev; | |||
| OFI_DBG_VAR(size_t, size); | |||
| OFI_DBG_VAR(struct dlist_entry *, list); | |||
There was a problem hiding this comment.
Remove ';' from end of the OFI_DBG_VAR() macro lines
|
I won't be able to work on this for the next few weeks |
Signed-off-by: Sai Sunku <sunkusa@amazon.com>
sunkuamzn
force-pushed
the
dlist-size
branch
from
ef073ff
to
a365b74
Compare
Signed-off-by: Sai Sunku <sunkusa@amazon.com>
sunkuamzn
force-pushed
the
dlist-size
branch
from
a365b74
to
f820b6d
Compare
| @@ -435,8 +439,10 @@ static inline struct slist_entry *slist_remove_head(struct slist *list) | |||
| item = list->head; | |||
| if (list->head == list->tail) | |||
| slist_init(list); | |||
| else | |||
| else { | |||
There was a problem hiding this comment.
nit: Please add braces to the if side if needed on the else side.
Useful for printing the size of the list during debugging