Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix bug about Controlling the Prompt. #51

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Fix bug about Controlling the Prompt. #51

wants to merge 1 commit into from

Conversation

drm343
Copy link

@drm343 drm343 commented Jan 25, 2019

Must enclosed not-printable sequences in [ and ] when use shml in prompt.
Or will overwrite the current line of screen and hard to see.

@drm343
Fix bug about Controlling the Prompt.
6048300 
Must enclosed not-printable sequences in \[ and \] when use shml in prompt.
Or will overwrite the current line of screen and hard to see.

Further reading:
* https://www.gnu.org/software/bash/manual/bashref.html#Controlling-the-Prompt
@drm343 drm343 mentioned this pull request Jan 25, 2019
Closed
@jdorfman
Copy link
Member

@drm343 thanks for this. @jmervine and I will take a look asap

@drm343
Copy link
Author

drm343 commented Jan 27, 2019

@drm343 thanks for this. @jmervine and I will take a look asap

I found "[" and "]" will print on screen if not use in PS1.
Maybe add 2 function named "Prompt_fgcolor" and "Prompt_bgcolor" for PS1 prompt is better.

@jmervine
Copy link
Member

I’ll take a look some point this week.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jmervine jmervine Awaiting requested review from jmervine

Assignees
No one assigned
Labels
in_review
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@drm343 @jdorfman @jmervine