Add exact drift element and map #66
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hi Nikita, thanks for the pull request. We'll look at it after the major code refactoring we're doing right now. |
nikitakuklev
force-pushed
the
dev_drift
branch
from
5c00ea6
to
ce575f6
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull request includes exact drift element, map, and test cases. Tracking results match MADX. Also, small fix to coupler kick, such that it is not used when no energy is specified.
Weirdly, many unrelated tests fail due to numerical precision issues, i.e.
r_matrix - matrix element (0, 5)\n value is "3.469446951953614e-17"\n reference value is "2.6237692574149207e-17"\n tolerance is "1e-07"\n tolerance type is "relative"in unit_tests\ebeam_test\acc_utils\acc_utils_test.py:14
I suspect this is due to platform/BLAS library differences, but please double check.