Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix a small bug of writing CMTSOLUTION file #2775

Open
wants to merge 5 commits into
base: master
Choose a base branch
from

Conversation

lynlyf
Copy link

@lynlyf lynlyf commented Jan 6, 2021

What does this PR do?

Please fill in

Why was it initiated? Any relevant Issues?

Please fill in

PR Checklist

  • Correct base branch selected? master for new features, maintenance_... for bug fixes
  • This PR is not directly related to an existing issue (which has no PR yet).
  • If the PR is making changes to documentation, docs pages can be built automatically.
    Just remove the space in the following string after the + sign: "+ DOCS"
  • If any network modules should be tested for the PR, add them as a comma separated list
    (e.g. clients.fdsn,clients.arclink) after the colon in the following magic string: "+TESTS:"
    (you can also add "ALL" to just simply run all tests across all modules)
  • All tests still pass.
  • Any new features or fixed regressions are be covered via new tests.
  • Any new or changed features have are fully documented.
  • Significant changes have been added to CHANGELOG.txt .
  • [*] First time contributors have added your name to CONTRIBUTORS.txt .

bug fix of writing CMTSOLUTION file
fix bugs in auto determination of ndk file format and the depth unit
change the value for the missing half duration of source time function from 1.0 to 0.0
plot_spectrogram returns figure handle
@ThomasLecocq
Copy link
Contributor

hi, thanks for the PR. Please:

  • provide context of why it is needed
  • provide an explanation about the choices of setting 0 instead of 1 for the STF
  • correct the contributors file, you didn't put your name at the right location (the one you modified links to the right file)

@lynlyf
Copy link
Author

lynlyf commented Sep 14, 2021

Hi Thomas,

I'm a bit confused. I apologize in advance if it's due to my mis-operations to pull all the changes (I always work locally with github and am not so familiar with the inter-repositories PRs).

I only requested a PR long time ago to fix the bug of writing the magnitudes in the CMTSOLUTION file [the commits on Jan 6, 2021]. The other changes were only made in my own repository. I changed the missing half duration values from 1.0 to 0.0 to distinguish missing values from existing values (over 100 events in the CMT catalog already have their half duration equal to 1.0). I'm not sure if other obspy users need such a utility.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants