libobs, plugins: Remove unnecessary output implementation calls #10652
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It's not referenced anywhere, and not exported.
This performs two output start steps internal to libobs: - `obs_output_can_begin_data_capture()` - `obs_output_initialize_encoders()` Both functions are implemented at the beginning of the `.start` callback in every output except for mpegts (where this does not affect behavior anyway). As such, it is not useful to make outputs call these functions, so let's just call them ourselves. Calling these functions multiple times is safe, for outputs which still have the old calls implemented.
See previous commit for reasoning.
Deprecates the following unnecessary functions: - `obs_output_can_begin_data_capture()` - `obs_output_initialize_encoders()` Both were made unnecessary to be called externally by prior commits, so we can now deprecate these functions.
tt2468
added
Code Cleanup
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Moves the initial calling of two output methods to libobs, and deprecates them:
obs_output_can_begin_data_capture()obs_output_initialize_encoders()Motivation and Context
After noticing that every output does effectively the same thing regarding these two functions, I determined that they could actually be moved to libobs entirely without any change in behavior. This cleans up a good amount of code and opens the door for further refactors of the outputs code later down the line.
How Has This Been Tested?
Ubuntu 22.04
Tested with every combination of:
Types of changes
Checklist: