Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add lost provenance back #10435

Merged
merged 2 commits into from
May 20, 2024
Merged

Add lost provenance back #10435

merged 2 commits into from
May 20, 2024

Conversation

matentzn
Copy link
Contributor

@matentzn matentzn commented Apr 3, 2024

This PR adds back some lost provenance for 8 synonyms that I think one of my automated pipelines removed.

These are just the ORCIDs of some of your Workshop participants @pnrobinson!

@matentzn matentzn requested a review from pnrobinson April 3, 2024 13:12
@pnrobinson
Copy link
Contributor

@matentzn I had to rearrange a few things that were erroneous and so I am not sure if the provenence is correct any more. I would just remove this for now to be honest.

@matentzn
Copy link
Contributor Author

matentzn commented Apr 3, 2024

Just wanted to do due dilligence - I think I literally did this - I did not change your rearrangements. This is only about unchanged synonyms that used to have provenance (aka attribution!) and now dont have any more and I am pretty sure this was my fault.

But, that said, I dont mind, just dont want to be blamed later for loosing metadata :D

You merge or close this PR as you see fit!

Copy link
Contributor

@pnrobinson pnrobinson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is just adding back some microannotations, correct? Let's merge!

@matentzn matentzn merged commit 2347ed8 into master May 20, 2024
1 check passed
@matentzn matentzn deleted the add-lost-provenance-back branch May 20, 2024 17:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants