-
-
Notifications
You must be signed in to change notification settings - Fork 479
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add the device authorization endpoint #844
base: master
Are you sure you want to change the base?
Conversation
@oliamb do you have time to address the lint issues, that might help get this on a maintainers radar for review. |
e7e02a2
to
2ab2822
Compare
Thanks @dopry. I did not even see that there was a lint issue. This should be fixed now. |
lets wait for the CI |
78cfc8d
to
f7c8369
Compare
The linter fails at other points now, but I can see this is from code outside the original PR. I rebased my branch on top of the master yesterday. I don't think I should fix files outside the PR scope, WDYT? I don't manage to get consistent results on my local with the linter because I think the linter libraries' versions are not pinned (i.e. they are installed through the command |
I would treat upstream lint issues as out of scope, if I did want to fix them I would submit it as a separate PR. |
Hello, what is the current status? Can this be merged? |
@auvipy do you have any thoughts on clearing the lint issues? |
This is a follow-up PR proposal for issue #626. It implements Section 3.1 and Section 3.2 of RFC8628. PR #640 is related and arguably more advanced. But it is a bit old now and relates to the draft specification.
This is my first submission here. I think I followed the Contributing Guidelines, but please let me know if I am doing it wrong.