Rename MetadataEndpoint._grant_types -> _grant_types_supported #808
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hello,
this PR renames the
_grant_types
attribute of theMetadataEndpoint
to_grant_types_supported
.Initially introduced in 6bd865b, the
_grant_types
attribute (typelist
) collides with the_grant_types
attribute (typedict
) of theTokenEndpoint
when inheriting from both classes.This caused a problem: If I want to create an
Server
-like combined endpoint inheriting from both theServer
andMetadataEndpoint
classes and pass a reference to an instance of this class to the constructor of theMetadataEndpoint
, initializing theMetadataEndpoint
will fail due to it settingself._grant_types
to a list but expecting each of the endpoint working on (which, in my case, includes the metadata endpoint itself) to be of typedict
.For example, the following code would fail:
A possible solution is renaming one of the
_grant_types
attributes. This PR does this.