Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change USER_COMMAND_MARK #1447

Closed
wants to merge 1 commit into from
Closed

Change USER_COMMAND_MARK #1447

wants to merge 1 commit into from

Conversation

olavfla
Copy link

@olavfla olavfla commented May 15, 2024

Change USER_COMMAND_MARK to include escape characters so that the non-printing characters are not counted towards prompt length.

… printing characters are not counted towards prompt length
@olavfla
Copy link
Author

olavfla commented May 15, 2024

Without this, experimental instant mode has an issue where line breaks occur 10 characters too early, making the terminal a bit wonky. Only tested with one terminal though

@olavfla
Copy link
Author

olavfla commented May 15, 2024

On a slightly related note, in def instant_mode_alias(self, alias_name) in shells/bash.py, is it really necessary with the backspaces in mark = USER_COMMAND_MARK + '\b' * len(USER_COMMAND_MARK)? In my experience, it works just fine without them, and fucks up if anything appends something to the start of PS1 (such as enabling a python venv).

@olavfla olavfla closed this May 25, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant