Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(nuxt): respect app.cdnURL for extracted payloads #26668

Merged
merged 5 commits into from May 23, 2024

Conversation

tresko
Copy link
Contributor

@tresko tresko commented Apr 5, 2024

馃敆 Linked issue

Resolves #22199

馃摎 Description

Support CDN URL when generating and fetching payload.

Copy link

stackblitz bot commented Apr 5, 2024

Review PR in StackBlitz Codeflow Run & review this pull request in StackBlitz Codeflow.

@tresko tresko changed the title feat(payload): support CDN URL feat(nuxt): support CDN URL Apr 5, 2024
Copy link

socket-security bot commented May 23, 2024

New and removed dependencies detected. Learn more about Socket for GitHub 鈫楋笌

Package New capabilities Transitives Size Publisher

馃毊 Removed packages: npm/fs-extra@10.1.0, npm/ignore@5.3.1, npm/jiti@1.21.0, npm/klona@2.0.6, npm/prettier@3.2.5, npm/typescript@5.4.5

View full report鈫楋笌

Copy link

socket-security bot commented May 23, 2024

馃毃 Potential security issues detected. Learn more about Socket for GitHub 鈫楋笌

To accept the risk, merge this PR and you will not be notified again.

Alert Package NoteSource
Telemetry npm/@nuxt/telemetry@2.5.4
  • Note: Can be disabled by setting the environment variable NUXT_TELEMETRY_DISABLED=1
  • orphan: npm/@nuxt/telemetry@2.5.4

View full report鈫楋笌

Next steps

What is telemetry?

This package contains telemetry which tracks how it is used.

Most telemetry comes with settings to disable it. Consider disabling telemetry if you do not want to be tracked.

Take a deeper look at the dependency

Take a moment to review the security alert above. Review the linked package source code to understand the potential risk. Ensure the package is not malicious before proceeding. If you're unsure how to proceed, reach out to your security team or ask the Socket team for help at support [AT] socket [DOT] dev.

Remove the package

If you happen to install a dependency that Socket reports as Known Malware you should immediately remove it and select a different dependency. For other alert types, you may may wish to investigate alternative packages or consider if there are other ways to mitigate the specific risk posed by the dependency.

Mark a package as acceptable risk

To ignore an alert, reply with a comment starting with @SocketSecurity ignore followed by a space separated list of ecosystem/package-name@version specifiers. e.g. @SocketSecurity ignore npm/foo@1.0.0 or ignore all packages with @SocketSecurity ignore-all

  • @SocketSecurity ignore npm/@nuxt/telemetry@2.5.4

@danielroe danielroe changed the title feat(nuxt): support CDN URL fix(nuxt): respect app.cdnURL for extracted payloads May 23, 2024
@danielroe danielroe merged commit 59ad152 into nuxt:main May 23, 2024
59 of 60 checks passed
@danielroe
Copy link
Member

Thank you 鉂わ笍

@github-actions github-actions bot mentioned this pull request May 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Payload URLs are missing the configured cdnURL
2 participants