Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DOC: Fixed NEP50 broken Link #26453

Closed
wants to merge 0 commits into from
Closed

Conversation

anushatomar13
Copy link

@anushatomar13 anushatomar13 commented May 16, 2024

I have fixed the issue mentioned in #26371
Please let me know if any additional changes are required.
Thanks
@melissawm

@mattip mattip changed the title Update 2.0.0-notes.rst: Fixed NEP50 broken Link DOC: Fixed NEP50 broken Link May 16, 2024
@mattip
Copy link
Member

mattip commented May 16, 2024

Please restore the removed line break. In order to build only documentation and not run the entire CI suite, you can add to your commit message [skip actions][skip azp][skip cirrus].

@anushatomar13
Copy link
Author

Dear @mattip,

I am encountering an issue regarding committing changes. I have attempted to restore the line break, but I am uncertain if this aligns with your expectations. Would you kindly review the latest commit and provide feedback?

As a new contributor to NumPy, I would greatly appreciate your guidance in resolving this matter. Thank you, and please accept my apologies for any inconvenience caused.

@mattip
Copy link
Member

mattip commented May 16, 2024

It seems you have done the opposite: now more content is contained on a single line. How are you editing the code?

@charris
Copy link
Member

charris commented May 16, 2024

The fix should be made against the maintenance/2.0.x branch. You should also work off a new branch in your fork.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants