-
-
Notifications
You must be signed in to change notification settings - Fork 9.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
CI: Enhance error handling in Azure Pipelines #26335
Conversation
…:: continueOnError Enhances error handling in Azure Pipelines by adding verbose logging, implementing continueOnError for non-critical steps, and improving condition checks and alerts for more robust CI/CD operations.
…ules are fetched before builds.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ensures that all 'git' submodules are fetched and initialized before the build and test steps commence, this update guarantees that all necessary code dependencies are present and up-to-date.
Hi @charris . Any chance this can get merged, or should we just close the PR? Thank you so much. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The changes to azure-steps-windows.yml are not needed. This is a template, it is injected into the azure-pipelines.yml file so should not have a trigger
and stages
stanza.
Is there some deeper motivation for this PR: is there an issue or problem it comes to solve?
pr: | ||
branches: | ||
include: | ||
- '*' # must quote since "*" is a YAML reserved character; we want a string | ||
|
||
- '*' # All branches for PRs |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Unindent?
@@ -50,8 +46,7 @@ stages: | |||
- script: >- | |||
python -m pip install -r requirements/linter_requirements.txt | |||
displayName: 'Install tools' | |||
# pip 21.1 emits a pile of garbage messages to annoy users :) | |||
# failOnStderr: true | |||
continueOnError: true |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't understand. How can the lint job succeed if the tools are not installed?
docker run -v $(pwd):/numpy -e CFLAGS="-msse2 -std=c99 -UNDEBUG" \ | ||
-e F77=gfortran-5 -e F90=gfortran-5 quay.io/pypa/manylinux2014_i686 \ | ||
/bin/bash -xc "source /numpy/tools/ci/run_32_bit_linux_docker.sh" | ||
displayName: 'Run 32-bit manylinux2014 Docker Build / Tests' | ||
continueOnError: true # Consider whether to allow continuation on error |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This seems wrong. If the tests fail, the job should fail
@morkev will you be continuing with this? |
@mattip Hi, thanks for tagging me. As you mentioned earlier, this PR does not solve any particular issue, and I would like to contribute with something better. For the exception part, I agree - why catch an error if you can’t handle it. The indentation was probably a mistake from the IDE, would only change if it’s better based on PEP 8 style guide. |
Enhance error handling in Azure Pipelines by adding verbose logging, implementing
continueOnError
for non-critical steps, and improving condition checks and alerts for more robust CI/CD operations.