Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Run formatting #246

Merged
merged 3 commits into from
Jan 14, 2024
Merged

Run formatting #246

merged 3 commits into from
Jan 14, 2024

Conversation

JElgar
Copy link
Member

@JElgar JElgar commented Jan 8, 2024

Description

Run formatting and enforce in ci

Fixes #<issue_number> or taiga link

Checklist:

Creator

  • The target branch is main
  • I have updated the unreleased section of the change log
  • I have reviewed the 'files changed' tab on github to ensure all changes are as expected
  • I have added someone to review the pr

Reviewer

  • I have verified the above are all completed
  • I have run the code locally to ensure it fufills the requirements of the issue
  • I have reviewed the 'files changed' and commented on any sections which I think are not needed, incorrect or could be improved

After pull

  • If appropriate I have closed the issue/ moved the trello card

Copy link

@kkogut-acrobits kkogut-acrobits left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for taking this into account!


typedef String MessageIfAbsent(String messageStr, List<dynamic> args);
typedef MessageIfAbsent = String Function(
String messageStr, List<dynamic> args);

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
String messageStr, List<dynamic> args);
String messageStr,
List<dynamic> args,
);

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hmm agreed... I think I tried to convince the linter that was a good idea a while ago and the was some spiel about how they don't let you do that. Let me check again.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah ok, thats apparently not part of dart format but part of dart fix... Not sure why and there also this open issue about something? dart-lang/dart_style#1253...

@JElgar JElgar force-pushed the formatting branch 2 times, most recently from 6b41b70 to 3811ce5 Compare January 14, 2024 09:45
@JElgar JElgar merged commit 7a4fe7a into main Jan 14, 2024
@JElgar JElgar deleted the formatting branch January 14, 2024 09:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants