Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

src: convert all endian checks to constexpr #52974

Merged
merged 1 commit into from
May 25, 2024
Merged

src: convert all endian checks to constexpr #52974

merged 1 commit into from
May 25, 2024

Conversation

tniessen
Copy link
Member

This is finally possible in C++20 without having to rely on compiler-defined macros, assuming none of our supported platforms are mixed-endian.

Refs: #44411

@tniessen
src: convert all endian checks to constexpr
7387c59 
This is finally possible in C++20 without having to rely on
compiler-defined macros, assuming none of our supported platforms are
mixed-endian.

Refs: nodejs#44411
@nodejs-github-bot nodejs-github-bot added c++ Issues and PRs that require attention from people who are familiar with C++. lib / src Issues and PRs related to general changes in the lib or src directory. needs-ci PRs that need a full CI run. labels May 14, 2024
anonrig
anonrig approved these changes May 14, 2024
View reviewed changes
src/util.h Show resolved Hide resolved
@richardlau richardlau added dont-land-on-v18.x PRs that should not land on the v18.x-staging branch and should not be released in v18.x. dont-land-on-v20.x PRs that should not land on the v20.x-staging branch and should not be released in v20.x. labels May 14, 2024
A19890

This comment was marked as spam.

Sign in to view

@tniessen tniessen added request-ci Add this label to start a Jenkins CI on a PR. author ready PRs that have at least one approval, no pending requests for changes, and a CI started. labels May 14, 2024
@github-actions github-actions bot removed the request-ci Add this label to start a Jenkins CI on a PR. label May 14, 2024
@nodejs-github-bot

This comment was marked as outdated.

Sign in to view
@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/59291/

@tniessen tniessen added the commit-queue Add this label to land a pull request using GitHub Actions. label May 25, 2024
@nodejs-github-bot nodejs-github-bot removed the commit-queue Add this label to land a pull request using GitHub Actions. label May 25, 2024
@nodejs-github-bot nodejs-github-bot merged commit 177b8b9 into nodejs:main May 25, 2024
75 checks passed
@nodejs-github-bot
Copy link
Collaborator

Landed in 177b8b9

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jasnell jasnell jasnell approved these changes

@A19890 A19890 A19890 left review comments

@anonrig anonrig anonrig approved these changes

Assignees
No one assigned
Labels
author ready PRs that have at least one approval, no pending requests for changes, and a CI started. c++ Issues and PRs that require attention from people who are familiar with C++. dont-land-on-v18.x PRs that should not land on the v18.x-staging branch and should not be released in v18.x. dont-land-on-v20.x PRs that should not land on the v20.x-staging branch and should not be released in v20.x. lib / src Issues and PRs related to general changes in the lib or src directory. needs-ci PRs that need a full CI run.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
6 participants
@tniessen @nodejs-github-bot @jasnell @anonrig @A19890 @richardlau