net: support 0 in IPv4 address
#52941
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Review requested:
|
nodejs-github-bot
added
needs-ci
|
Did you run the test suite before sending the PR? |
Haha! I ran the IPv6 test suite by accident, I'll fix it now. |
|
This feels like a semver-major change to me. Libraries and applications may require the current, stricter, checks. |
|
Maybe, I'm closing this now (as I didn't put the thought into it that it needed), but I ,might reconsider later. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
IPv4 addresses can contain leading
0s in any segment, so this PR updates the RegEx to account for those.(
01.1.1.1->1.1.1.1, etc)