Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[v18 backport] test: add v8-updates/test-linux-perf-logger #52925

Closed
wants to merge 2 commits into from
Closed

[v18 backport] test: add v8-updates/test-linux-perf-logger #52925

wants to merge 2 commits into from

Conversation

lukealbao
Copy link
Contributor

@lukealbao lukealbao commented May 9, 2024 •
edited

v18 bullet point from #51308

This patch backports the test/v8-updates/test-linux-perf-logger.js test from #50352 to the v18 branch.

Related to #50079, this test suite includes the same assertions as those done in test/v8-updates/test-linux-perf.js. The difference is that this suite doesn't require perf(1) to be available to CI workers. To that end, it may be the case that this test could simplify and replace the perf integration test. /cc @richardlau

@lukealbao
test: v8: Add test-linux-perf-logger test suite
7d8fec9 
Cherry-picked from 9c714d8

PR-URL: nodejs#50352
Reviewed-By: Michael Dawson <midawson@redhat.com>
Reviewed-By: Richard Lau <rlau@redhat.com>
Reviewed-By: Vinícius Lourenço Claro Cardoso <contact@viniciusl.com.br>
@lukealbao
Add maintainers' note re: v8 options failure modes
dacfd73
@nodejs-github-bot nodejs-github-bot added needs-ci PRs that need a full CI run. test Issues and PRs related to the tests. v18.x Issues that can be reproduced on v18.x or PRs targeting the v18.x-staging branch. labels May 9, 2024
@richardlau richardlau added the request-ci Add this label to start a Jenkins CI on a PR. label May 9, 2024
@github-actions github-actions bot removed the request-ci Add this label to start a Jenkins CI on a PR. label May 9, 2024
@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/59066/

@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/59070/

@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/59072/

@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/59074/

@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/59075/

@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/59076/

richardlau pushed a commit that referenced this pull request May 16, 2024
@lukealbao @richardlau
test: v8: Add test-linux-perf-logger test suite
351ef18 
Cherry-picked from 9c714d8

PR-URL: #50352
Backport-PR-URL: #52925
Reviewed-By: Michael Dawson <midawson@redhat.com>
Reviewed-By: Richard Lau <rlau@redhat.com>
Reviewed-By: Vinícius Lourenço Claro Cardoso <contact@viniciusl.com.br>
@richardlau
Copy link
Member

Landed in 351ef18.

@richardlau richardlau closed this May 16, 2024
@lukealbao lukealbao deleted the gh-51308-add-test-linux-perf-logger-to-v18x branch May 28, 2024 19:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@targos targos targos approved these changes

@richardlau richardlau richardlau approved these changes

Assignees
No one assigned
Labels
needs-ci PRs that need a full CI run. test Issues and PRs related to the tests. v18.x Issues that can be reproduced on v18.x or PRs targeting the v18.x-staging branch.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@lukealbao @nodejs-github-bot @richardlau @targos