-
Notifications
You must be signed in to change notification settings - Fork 28.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
tools: fix riscv64 build failed #52888
base: main
Are you sure you want to change the base?
Conversation
Review requested:
|
I had a try with your branch with GCC10 from Ubuntu 20.04/riscv64 and run into an issue with a number of symbols when building the test code - is that expected and do you get the same failure? I don't think I've seen these before.
EDIT: I'm going to be away for the next 2½ weeks - so until June - so if I don't respond to any further queries on this, that will be why |
Why does that check for host_arch=="arm64" or target_arch=="arm64"? |
- Backport nodejs/node#52888 - Seems crash when building with gcc had fixed, use GCC again.
- Backport nodejs/node#52888 - Seems crash when building with gcc had fixed, use GCC again.
- Backport nodejs/node#52888 - Seems crash when building with gcc had fixed, use GCC again.
fix #52678