[CodeClean] fix svace issue #4462
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jaeyun-jung
requested review from
myungjoo,
jijoongmoon,
again4you,
wooksong,
gichan-jang,
anyj0527,
songgot,
jihochu,
niley7464,
yeonykim2 and
a team
as code owners
jaeyun-jung
force-pushed
the
svace-prevent-underflow
branch
from
89811b4
to
69e95af
Compare
songgot
reviewed
May 20, 2024
| @@ -727,7 +727,8 @@ gst_tensor_query_client_chain (GstPad * pad, | |||
| data_h = g_async_queue_timeout_pop (self->msg_queue, | |||
| self->timeout * G_TIME_SPAN_MILLISECOND); | |||
| if (data_h) { | |||
| self->requested_num--; | |||
| if (self->requested_num > 0) | |||
There was a problem hiding this comment.
need { } in lines 730 to 769?
There was a problem hiding this comment.
yes, pushing buffer to downstream element occurs when a data processed from query-server in the queue.
songgot
reviewed
May 20, 2024
Comment on lines
+731
to
734
| self->requested_num--; | ||
| ret = nns_edge_data_get_count (data_h, &num_data); | ||
|
|
||
| if (ret == NNS_EDGE_ERROR_NONE && num_data > 0) { |
There was a problem hiding this comment.
Sorry,
Should code(line 732 ~ 769) be done when self->requested_num > 0 is TRUE ?
There was a problem hiding this comment.
Actually unnecessary. The param self->requested_num is required for limiting max input to query-server.
query-client handles the response from query-server by using msg-queue.
jaeyun-jung
force-pushed
the
svace-prevent-underflow
branch
from
69e95af
to
b201910
Compare
jihochu
reviewed
May 23, 2024
| @@ -173,10 +173,15 @@ PYConverterCore::convert (GstBuffer *in_buf, GstTensorsConfig *config) | |||
|
|
|||
| if (output) { | |||
| GstTensorInfo *_info; | |||
| unsigned int num_tensors = PyList_Size (output); | |||
| unsigned int num_tensors = (unsigned int) PyList_Size (output); | |||
There was a problem hiding this comment.
Return of PyList_Size coud be negative, so how about checking error ?
unsigned int num_tensors = NNS_TENSOR_SIZE_LIMIT + 1;
Py_ssize_t out_len = PyList_Size (output);
if (out_len >= 0)
num_tensors = (unsigned int) out_len;
There was a problem hiding this comment.
I changed param type (Py_ssize_t), please review the changes again.
jaeyun-jung
force-pushed
the
svace-prevent-underflow
branch
3 times, most recently
from
c826e40
to
6bd4dcb
Compare
|
Code clean, fix svace issues. - check max number of tensors and prevent underflow. Signed-off-by: Jaeyun Jung <jy1210.jung@samsung.com>
jaeyun-jung
force-pushed
the
svace-prevent-underflow
branch
from
6bd4dcb
to
0e0473e
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Code clean, fix svace issues.