Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[WIP] enh: turn interface into callable #2724

Open
wants to merge 5 commits into
base: master
Choose a base branch
from
Open

[WIP] enh: turn interface into callable #2724

wants to merge 5 commits into from

Conversation

satra
Copy link
Member

@satra satra commented Oct 10, 2018

turning interfaces into a callable to support dask based operations.

@effigies
Copy link
Member

If this is for Nipype 1.x, could you set the milestone to 1.1.4?

If this is for Nipype 2.0, could you set the target branch to dev/2.0 and the milestone to Nipype 2.0?

@oesteban oesteban added this to the 1.1.4 milestone Oct 15, 2018
@oesteban
Copy link
Contributor

I think this should work in nipype 1.0 without much trouble. Therefore, I see under 1.0 anything that makes the jump between 1.0 and 2.0 easier but does not mean to actually implement 2.0.

@codecov-io
Copy link

codecov-io commented Oct 15, 2018 •
edited

Codecov Report

Merging #2724 into master will decrease coverage by 3.41%.
The diff coverage is 33.33%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #2724      +/-   ##
==========================================
- Coverage   67.44%   64.02%   -3.42%     
==========================================
  Files         340      338       -2     
  Lines       43164    43122      -42     
  Branches     5351     5350       -1     
==========================================
- Hits        29110    27610    -1500     
- Misses      13355    14445    +1090     
- Partials      699     1067     +368
Flag Coverage Δ
#smoketests ?
#unittests 64.02% <33.33%> (-0.79%) ⬇️
Impacted Files Coverage Δ
nipype/interfaces/base/core.py 85.86% <33.33%> (-2.29%) ⬇️
nipype/interfaces/nilearn.py 40% <0%> (-56.67%) ⬇️
nipype/utils/spm_docs.py 25.92% <0%> (-44.45%) ⬇️
nipype/interfaces/freesurfer/base.py 49.59% <0%> (-30.9%) ⬇️
nipype/utils/logger.py 59.7% <0%> (-29.86%) ⬇️
nipype/algorithms/rapidart.py 35.39% <0%> (-29.21%) ⬇️
nipype/interfaces/spm/base.py 58.41% <0%> (-29.05%) ⬇️
nipype/utils/provenance.py 55.73% <0%> (-28.99%) ⬇️
nipype/interfaces/fsl/model.py 55.26% <0%> (-25.35%) ⬇️
nipype/testing/fixtures.py 77.33% <0%> (-21.34%) ⬇️
... and 45 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 39675df...3d347ad. Read the comment docs.

@effigies
Copy link
Member

Anything left to this one?

@satra
Merge branch 'master' into enh/callable
73c0e00 
* master: (27 commits)
  add optional output sse to FSL dtifit interface
  update specs
  [ENH] Move ``nipype.interfaces.ants.LaplacianThickness`` to use ``name_source``
  FIX: only select outputs created by split
  pep errors and use sets for tab_completion comparisons
  tidy code for tab comletion of inputs and outputs
  remove superfluous __all__ definition
  make fix for tab_comnpletion test
  make tab_comletion test function a normal function
  fix tab completion for dynamic traits and tidy tests
  add tab completion with tests
  modify BaseTraitedSpec for tab completion
  BF: reuse _gen_filename logic for output_name if not defined
  Fix doctest
  Make mrtrix3 FitTensor reg_term conditional on version
  BF: provide "" into target graph dot depending on networkx version
  FIX: Pin coverage<5
  [FIX] Pin codecov to <5.0 so Travis is fixed
  ENH: enable/disable resource monitor in the fixture per test
  FIX: revert changes in generate_dockerfiles.sh
  ...
@satra
Merge remote-tracking branch 'origin/enh/callable' into enh/callable
c71ddad 
* origin/enh/callable:
satra
satra commented Oct 25, 2018
View reviewed changes
nipype/interfaces/base/core.py Outdated Show resolved Hide resolved
@effigies effigies mentioned this pull request Oct 26, 2018
Merged
12 tasks
@effigies effigies modified the milestones: 1.1.4, 1.1.5 Oct 31, 2018
@effigies effigies modified the milestones: 1.1.5, 1.1.6 Nov 7, 2018
@effigies effigies modified the milestones: 1.1.6, 1.1.7 Nov 26, 2018
@effigies effigies modified the milestones: 1.1.7, 1.1.8 Dec 14, 2018
@effigies
Copy link
Member

Hi, just a reminder that the 1.1.8 release is targeted for January 28. Please let us know if you'd like to try to finish this up for that release.

@effigies effigies mentioned this pull request Jan 25, 2019
Merged
16 tasks
@effigies effigies modified the milestones: 1.1.8, future Jan 27, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@effigies effigies effigies left review comments

@oesteban oesteban oesteban left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
future
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@satra @effigies @oesteban @codecov-io