ENH: Add classes for CommandLine interfaces with input passed via env or stdin #2493
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… or stdin Adds StdInCommandLine and EnvironmentInputCommandLine
|
Comments/criticisms welcome |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds StdInCommandLine and EnvironmentInputCommandLine
What is this?
I have implemented this for some custom Interfaces that I have had to create. They wrapped scripts that either took inputs as environment variables, or were interactive scripts that prompted the user and asked for input via stdin.
I included a basic test case (using
sedthe stream editor) to demonstrate how they are used.I'm interested to hear what the maintainers think about these changes, since they don't actually support any of the Interfaces within Nipype. I am currently just maintaining the changes in parallel to development.