Nipype multiproc plugin modification to use GPU(s) as resources. #2298
Conversation
nipype/interfaces/base.py
Outdated
| self._cmd = command or getattr(self, '_cmd', None) | ||
|
|
||
| if self._cmd is None: | ||
| if not hasattr(self, '_cmd'): |
There was a problem hiding this comment.
this bit should be reverted as the above command is equivalent.
| self.n_gpu_proc = self.plugin_args.get('ngpuproc', 1) | ||
|
|
||
| # Check plugin args | ||
| if self.plugin_args: |
There was a problem hiding this comment.
i think this if self.plugin_args can be eliminated.
|
|
||
| #form a GPU queue first | ||
| gpus=[] | ||
| try: |
There was a problem hiding this comment.
this try catch is similar to gpu_count below. perhaps can be refactored to a common function.
|
it would be good to merge this with master and resolve the conflicts. |
|
@schahid - is this something you can take care of? or should we take it over? |
|
@satra - sorry for the delay in replying...as i am on holidays...yes sure you can take it over. thanks a lot. |
|
just putting a note here that with the reorganization of this module in release 1.0, this will require some significant merge effort. |
|
Foolishly enough, I took a shot at that some time last week. master...effigies:enh/gpu_management Since it's @schahid's |
Codecov Report
@@ Coverage Diff @@
## master #2298 +/- ##
==========================================
- Coverage 66.66% 66.42% -0.24%
==========================================
Files 328 339 +11
Lines 42529 47398 +4869
Branches 5278 5317 +39
==========================================
+ Hits 28350 31485 +3135
- Misses 13500 15171 +1671
- Partials 679 742 +63
Continue to review full report at Codecov.
|
Fixes # .
Changes proposed in this pull request