MincHeader.get_xyzt_units() #1098
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hello @jennydaman, Thank you for updating! Cheers! There are no style issues detected in this Pull Request. 🍻 To test for issues locally, Comment last updated at 2022-04-01 19:46:07 UTC |
Codecov Report
@@ Coverage Diff @@
## master #1098 +/- ##
==========================================
- Coverage 92.29% 92.14% -0.15%
==========================================
Files 100 100
Lines 12247 12269 +22
Branches 2393 2398 +5
==========================================
+ Hits 11303 11305 +2
- Misses 621 633 +12
- Partials 323 331 +8
Continue to review full report at Codecov.
|
|
Possibly convergent work: #567 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The headers of MINC files have information which specifies the volume units (almost always mm). This PR exposes the data via
MincHeader.get_xyzt_units(), which is homologous toNifti1Header.get_xyzt_units(). But I don't work with 4D MINC so the 't' unit is simply"unknown".I'm thinking that it would be nice to have
get_xyzt_units()part of the header interface.This PR is kind of a draft? It works, though my intention is to open a discussion and perhaps support
get_xyzt_units()for other file formats too.