ENH: Add development dockerfile for testing local changes to repo. #1299
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
oesteban
reviewed
May 20, 2024
Comment on lines
+60
to
+61
| New python dependencies can be added in `pyproject.toml` under `dependencies`. Any time a dependency is changed | ||
| or added there the docker image will need to be rebuilt using the above `docker build` command. |
There was a problem hiding this comment.
Suggested change
| New python dependencies can be added in `pyproject.toml` under `dependencies`. Any time a dependency is changed | |
| or added there the docker image will need to be rebuilt using the above `docker build` command. | |
| New Python dependencies can be added in ``pyproject.toml`` under ``dependencies``. | |
| Any time a dependency is changed or added there the docker image will need to be rebuilt | |
| using the above ``docker build`` command. |
| Development | ||
| ----------- | ||
| A local development build based on the latest docker build of MRIQC can be built with this command run from | ||
| the root of this repository: |
There was a problem hiding this comment.
Suggested change
| the root of this repository: | |
| the root of this repository:: |
|
|
||
| docker build -f Dockerfile_devel -t mriqc_devel . | ||
|
|
||
| To test changes the local source code will need to be mounted into the development container: |
There was a problem hiding this comment.
Suggested change
| To test changes the local source code will need to be mounted into the development container: | |
| To test changes the local source code will need to be mounted into the development container:: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.