-
Notifications
You must be signed in to change notification settings - Fork 575
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[ENH] add footer to all masker reports #4307
base: main
Are you sure you want to change the base?
Conversation
👋 @Remi-Gau Thanks for creating a PR! Until this PR is ready for review, you can include the [WIP] tag in its title, or leave it as a github draft. Please make sure it is compliant with our contributing guidelines. In particular, be sure it checks the boxes listed below.
For new features:
For bug fixes:
We will review it as quick as possible, feel free to ping us with questions if needed. |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #4307 +/- ##
==========================================
+ Coverage 91.85% 91.99% +0.13%
==========================================
Files 144 145 +1
Lines 16419 16710 +291
Branches 3434 3551 +117
==========================================
+ Hits 15082 15372 +290
+ Misses 792 767 -25
- Partials 545 571 +26
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
For reviewBefore (current dev doc)
After |
I like the change. |
Given that this is not a bug fix (next release should be mostly bug fixes) I think we can take the time to think about it and possibly find a way to not display them in notebooks. |
probably worth refactoring the CSS across reports first
|
Given that I am working on the surface masker reports I am getting back to this one too. @emdupre (given our previous convo) can you have a look and let me know if you feel this one extra-line in the report would be too much of an eye-sore for notebook users? 😜 HTMLmasker_reports_with_footer.zip Notebooks |
Changes proposed in this pull request: