Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ENH] add footer to all masker reports #4307

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

Remi-Gau
Copy link
Collaborator

@Remi-Gau Remi-Gau commented Mar 4, 2024

Changes proposed in this pull request:

  • add footer to masker reports

Copy link
Contributor

github-actions bot commented Mar 4, 2024

👋 @Remi-Gau Thanks for creating a PR!

Until this PR is ready for review, you can include the [WIP] tag in its title, or leave it as a github draft.

Please make sure it is compliant with our contributing guidelines. In particular, be sure it checks the boxes listed below.

  • PR has an interpretable title.
  • PR links to Github issue with mention Closes #XXXX (see our documentation on PR structure)
  • Code is PEP8-compliant (see our documentation on coding style)
  • Changelog or what's new entry in doc/changes/latest.rst (see our documentation on PR structure)

For new features:

  • There is at least one unit test per new function / class (see our documentation on testing)
  • The new feature is demoed in at least one relevant example.

For bug fixes:

  • There is at least one test that would fail under the original bug conditions.

We will review it as quick as possible, feel free to ping us with questions if needed.

Copy link

codecov bot commented Mar 5, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 91.99%. Comparing base (abb80ff) to head (43ead12).
Report is 82 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #4307      +/-   ##
==========================================
+ Coverage   91.85%   91.99%   +0.13%     
==========================================
  Files         144      145       +1     
  Lines       16419    16710     +291     
  Branches     3434     3551     +117     
==========================================
+ Hits        15082    15372     +290     
+ Misses        792      767      -25     
- Partials      545      571      +26     
Flag Coverage Δ
macos-latest_3.10_test_plotting 91.77% <100.00%> (?)
macos-latest_3.11_test_plotting 91.77% <100.00%> (-0.08%) ⬇️
macos-latest_3.9_test_plotting 91.74% <100.00%> (?)
ubuntu-latest_3.10_test_plotting 91.77% <100.00%> (-0.08%) ⬇️
ubuntu-latest_3.11_test_plotting 91.77% <100.00%> (?)
ubuntu-latest_3.8_test_min 68.75% <0.00%> (?)
ubuntu-latest_3.8_test_plot_min 91.44% <100.00%> (?)
ubuntu-latest_3.8_test_plotting 91.73% <100.00%> (?)
ubuntu-latest_3.9_test_plotting 91.74% <100.00%> (?)
windows-latest_3.11_test_plotting 91.76% <100.00%> (?)
windows-latest_3.9_test_plotting 91.73% <100.00%> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@bthirion
Copy link
Member

bthirion commented Mar 6, 2024

I like the change.

@Remi-Gau
Copy link
Collaborator Author

Remi-Gau commented Mar 6, 2024

Given that this is not a bug fix (next release should be mostly bug fixes) I think we can take the time to think about it and possibly find a way to not display them in notebooks.

@Remi-Gau
Copy link
Collaborator Author

Remi-Gau commented Apr 9, 2024

probably worth refactoring the CSS across reports first

@Remi-Gau Remi-Gau marked this pull request as ready for review June 6, 2024 08:11
@Remi-Gau Remi-Gau changed the title [ENH] add footer to all reports [ENH] add footer to all masker reports Jun 6, 2024
@Remi-Gau
Copy link
Collaborator Author

Remi-Gau commented Jun 6, 2024

Given that I am working on the surface masker reports I am getting back to this one too.

image

@emdupre (given our previous convo) can you have a look and let me know if you feel this one extra-line in the report would be too much of an eye-sore for notebook users? 😜

HTML

masker_reports_with_footer.zip

Notebooks

visualize_reports_in_notebook.zip

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Standardize footer of reports
2 participants